Skip to content
This repository has been archived by the owner on Nov 10, 2020. It is now read-only.

Layout spillover #1597

Closed
9 of 14 tasks
gemfarmer opened this issue Jul 13, 2016 · 3 comments
Closed
9 of 14 tasks

Layout spillover #1597

gemfarmer opened this issue Jul 13, 2016 · 3 comments
Assignees

Comments

@gemfarmer
Copy link
Contributor

gemfarmer commented Jul 13, 2016

Remaining work from #1592, #1518


  • Federal production data isn't working on some states (see Arizona and Washington) (perhaps it is the states that have the random 100 years of data for a few commodities) --mhz
  • map legend years need to update on year switch
  • Map legend filtering needs to update without white space
  • Color swatches on map should based on absolute (rather than relative) scale
  • add year switcher functionality to the mega chart (probably means making the megachart a component) We don't need to look at every year here. --mhz
  • bar chart sentences need to handle $0 values discussed here
  • bar charts need to handle 0 values new issue for this here
  • when sections don't have any data for any years, hide selector, bar chart and map
  • fix uneven heights on .chart-title element (easiest solution here is to make all headers short enough to fit on one line)
  • get rid of "Details" toggles that are no longer needed. Remove commented out code.
  • wide maps should have horizontal legend see this comment

    Things that need to update when a year is switched (and currently aren't updating)


  • legend description
  • Section description. Currently if the page is rendered on a year, that text is set to that year, even if another year might have different associated text
  • county-level bar charts
This was referenced Jul 13, 2016
@ericronne
Copy link
Contributor

ericronne commented Jul 15, 2016

I'm marking up some typographic adjustments, but here are a few other tweaks for starters (mostly re bar styling). Thx @gemfarmer! ...

  • Create a new section header, "Production in the entire state of Utah" (see image below).
  • Extra space should go above single-line heads, not below it.
  • Numbers and text in surrounding sentences seem large.
  • If @coreycaitlin agrees, delete the periods after data sentences
  • Can we slightly reduce the vertical space between the tops of the bars and the data sentence above them? (brian: this should be part of an effort to make these mobile friendly.)
  • ENHANCEMEHT: testing surfaced the need for a Y-axis label, which could look like the inset design below.
  • Charts are too close horizontally, see image here (padding on right)

image

@ericronne
Copy link
Contributor

@gemfarmer
Here's a reference image for some type fixes, tyvm!...

image

@gemfarmer
Copy link
Contributor Author

gemfarmer commented Jul 27, 2016

From conversation with @ericronne

  • tile header alignment: if there is a discrepancy between chart-title heights, make the one-row title hug the line rule with space above it.
  • 0 values in bar charts:
    • there should be a difference between values of 0 and unreported data
    • this will involve going back through the data and remaking the outputted data so that we can distinguish between the two.

This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants