This repository has been archived by the owner on Nov 10, 2020. It is now read-only.
use datatype metadata #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shawnbot thank you thank you this is way cleaner! I say merge. |
|
@shawnbot actually looking into this longer, I noticed the logic for filtering the data in the |
13 tasks
added 14 commits
October 8, 2015 09:59
|
All you, @gemfarmer! |
|
Let's get this merged! 🚢 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a proposal for how we can handle the problem of different data types having drastically different URLs and structures (column names, etc.). It puts all of the data types into a Jekyll site data file (
_data/datatypes.yml) and uses that both to output the<select>element for choosing a data type and introduces aDataTypeclass on the JavaScript side that determines the data URL from each data type's "spec".Let me know what you think, @gemfarmer!