This repository has been archived by the owner on Nov 10, 2020. It is now read-only.
Explore > Exports #936
Merged
Explore > Exports #936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return req; | ||
| }; | ||
|
|
||
| function getDataURL(state) { |
|
This looks great, @gemfarmer. A couple of things, though:
|
| @@ -95,7 +95,8 @@ async.waterfall([ | |||
| rows.forEach(function(d, i) { | |||
| if (i === 0) console.warn(d, years); | |||
| years.forEach(function(year) { | |||
| var value = +d['val' + year]; | |||
| var value = +d['val' + year] * 1e6; | |||
| var share = +d['share' + year.substr(-2)] / 100 | |||
|
@gemfarmer I say merge this for now and file the nationwide issue as a separate bug to make sure we are pushing as much as we can out for review. |
|
Ok. I'll merge and make a separate issue detailing the issue. ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #858, #685, #681 (code, design, wireframe)
Preview: https://federalist.18f.gov/preview/18F/doi-extractives-data/exports/explore/exports
It is good to go! I used gdp as a template and referred to wireframes in #681.
Questions/todos remaining:
@Isabelle1512, @shawnbot suggested that I talk to you about holes in the exports data.
What's going on: we don't have nationwide totals, so we can't accurately asses the Nationwide $ total or % of total exports.
Do you know where we can get Nationwide total $s and % ? I looked in the executive summary and only found values for specific years and specific industries.
@meiqimichelle Should the problem above be treated as a bug or blocker? We can merge this and file the Nationwide values as separate bugs to be addressed separately. Or we could wait for the data