Ale Path Expansion Fixes #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #551 +/- ##
==========================================
- Coverage 16.91% 16.89% -0.03%
==========================================
Files 54 54
Lines 5865 5872 +7
==========================================
Hits 992 992
- Misses 4873 4880 +7
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jrcain-usgs
approved these changes
Aug 7, 2023
Kelvinrr
added a commit
that referenced
this pull request
Sep 29, 2023
* Fixes LRO minirf driver * Reverted gitignore * Reverted sensor_frame_id override * Added naifkeyword test for minirf * Added changelog entry * Updated minirf json * Lunar orbiter high camera (#553) * skeleton class for LO * lo center time and ikid * detector center line/sample dummy values * LO driver (processes cube w/o error) * lo test data * lunar orbiter tests * removed old comment * removed geotransform and projection from ISD * Clementine LWIR, NIR, and HIRES Drivers (#565) * Clementine Drivers * Added missing kernels * Combined to one driver * Updated doc strings * MSL Nadir Pointing (#564) * Enabled nadir pointing in MSL/CAHVOR driver * Removed commented out position changes * Fix MSL test * More msl fiddling * Update for MSL Nadir pointing rotation in the cahvor mixin * Fixed msl tests and added nadir test * Updated ALE version in CmakeList.txt (#555) * Ale Path Expansion Fixes (#551) * Fixed expandvar function to expand paths completely * Made expandvars fail if it can't expand a variable * fixed typo --------- Co-authored-by: Jacob Cain <115182890+jrcain-usgs@users.noreply.github.com> Co-authored-by: Amy Stamile <74275278+amystamile-usgs@users.noreply.github.com> Co-authored-by: Kelvin <krodriguez@usgs.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users were dealing with weird interactions between ALE and ISIS w.r.t. ISIS preference files. If users had old preference files there paths would expand as such:
$lro/path/to/lro/kernel$ISIS3DATA/lro/path/to/lro/kernel$ISISDATA/lro/path/to/lro/kernelThen stop there since we only expected paths to contain one ISIS preference defined variable and one os.environ variable. This prevents ALE from being able to get spice data for anything since the paths didn't fully unwrap.
This PR changes the expandvar function to expand all IsisPreference variables and env variables. If we cannot expand a variable the function now errors out.