Minirf Fixes #563
Merged
Minirf Fixes #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* skeleton class for LO * lo center time and ikid * detector center line/sample dummy values * LO driver (processes cube w/o error) * lo test data * lunar orbiter tests * removed old comment * removed geotransform and projection from ISD
Kelvinrr
reviewed
Sep 20, 2023
* Clementine Drivers * Added missing kernels * Combined to one driver
Kelvinrr
reviewed
Sep 27, 2023
ale/drivers/lro_drivers.py
Outdated
| @@ -819,7 +819,9 @@ def ephemeris_start_time(self): | |||
| @property | |||
| def ephemeris_stop_time(self): | |||
| """ | |||
| Returns the stop ephemeris time for the image. | |||
| Returns the stop ephemeris time for the image. This is computed from | |||
| the start time plus the line exposure per line, plue the line exposure | |||
* Enabled nadir pointing in MSL/CAHVOR driver * Removed commented out position changes * Fix MSL test * More msl fiddling * Update for MSL Nadir pointing rotation in the cahvor mixin * Fixed msl tests and added nadir test
* Fixed expandvar function to expand paths completely * Made expandvars fail if it can't expand a variable
…cpaquette-minirf_fix
Kelvinrr
previously approved these changes
Sep 29, 2023
acpaquette
dismissed
Kelvinrr’s stale review
The merge-base changed after approval.
acpaquette
added a commit
that referenced
this pull request
Oct 13, 2023
This reverts commit 695d312.
Merged
Kelvinrr
pushed a commit
that referenced
this pull request
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #5282 in ISIS. The issue is the result of the minirf driver not updating the translation keywords with the right translation.