Adds valid height check for DEM intersection #121
Conversation
|
@acpaquette I just realized that this repo has not testing CI 😨!! This PR is passing locally (with warnings related to the PVL library). How do you want to proceed? I don't want this to become an uber PR. I can open another PR with testing setup, we can get that merged, and then re-review/re-run this one. Or you could pull this PR local, also verify that it is passing and then we can get an issue open. I did not mean for this to become a thing! |
tests/test_csm.py
Outdated
| @mock.patch.object(csm, 'get_radii', return_value=(10,10)) | ||
| @mock.patch('pyproj.transformer.Transformer.transform', return_value=(0,0,0)) | ||
| @mock.patch.object(csm, '_compute_intersection_distance', return_value=0) | ||
| def test_generate_ground_point_with_dtm(mock_sensor, pt, _): |
There was a problem hiding this comment.
As far as I can tell, pytest is counting the number of decorators and then assuming that n-decorators == n-args to the func. To get the test parser to work, I added the _ arg. This seems super janky. Any thoughts on whether this approach should be different?
There was a problem hiding this comment.
I'm not sure here, you might try putting the other mock.patch.object above the mock.patch. Some of pythons test suite is very order dependent
There was a problem hiding this comment.
This comment was 💰. The mock.patch.object needs to be passed into the test as an arg. The order is also important where the mocked stuff needs to be first in the test signature, then any fixtures.
Local results with this setup: 5 passed, 4 warnings in 1.89s
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: