Adds Kaguya TC Support #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking in data.db, I am only seeing an entry added for TC2 and nothing for TC1. |
|
Crud - thought this was a PR adding 1...I"ll add it. |
Kelvinrr
pushed a commit
to Kelvinrr/plio
that referenced
this pull request
May 26, 2022
ladoramkershner
pushed a commit
to ladoramkershner/plio
that referenced
this pull request
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the necessary translation lines to the db to support KaguyaTC. This was spot checked against ISIS3.7.1 using
getsnfor a few cubes. Looks like the SN is super standard (MIssion/Instrument/Time) so I am pretty confident in this being good to go.@ladoramkershner Can you pull this local and give it a look? If it looks good I will update this PR with the version bumps so that we can release an updated version that support KaguyaTC.