-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compare scripts should be build using language defaults #1238
Comments
I fully agree - are you willing to contribute this? |
Yes I'll give this a try. I think these scripts are already fetched and used for compiling team submissions right, so it shouldn't be too much work |
I think I should be able to reuse most of the existing The tricky point is mapping an executable to a compile script/id. It seems that currently no language detection is done on the judgedaemons, so they would need to fetch this information from the database first, right? (Of course we could still keep the switch over extensions, but that feels wrong.) Then, we need the up date Basically, it seems that we need to query the database each time before compiling an executable. Is that possible, and does it sounds like the right approach? Also, here's a pedantic case: Suppose the executable for the (But this is easily avoided by disabling the language-detection for language-compile executables, and only doing it for compare scripts.) |
Oh, or we could do language detection for executables early on and store it in the DB, and then send this language, together with compile config when the executable is fetched here |
Currently the judgedaemon has hardcoded compile commands for executables (output validators / interactors).
It would be nicer if this reused the configured language compile scripts from the DOMserver settings, i.e. the default
build
andrun
script for the language.The text was updated successfully, but these errors were encountered: