-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compare script language defaults #2135
Conversation
See: https://ccs-specs.icpc.io/2023-06/contest_api?highlight=args#languages The fields are not exposed yet in the API, not shown on the page yet and not used for actual building yet.
We can now also set the default for the version command to remove some duplication. This would according to spec already be picked if we leave the field empty but explicit is always better.
I cannot really review this on my tiny phone screen, just wanted to leave two comments: I started some work in this direction here #1241 - we probably want to use the same mechanism to pass in flags for both? Historically speaking, we decided explicitly not to use the configured languages as you might have different options for submissions and validators. I think this is worth reconsidering; my current gut feeling is that we could do something like this: |
I'll wait for you to be on a larger screen,
That was the intent, I extended the language object with the CLICS flags {runner,compiler} where you had those specific for the
This PR was to work towards #1238, where it was proposed (if I understand correctly) to explicit use the same options. |
If I understand things correctly, after this PR languages will have fields in the UI that ask for compiler/runner and their args. But these commands are not used for the submission language, and only for the validators which can be very confusing (while the code is clean). My proposal is actually to not introduce the new fields in the UI as a first step, but move to using the same executables that we use for submission languages for validators. This will allow us to:
|
Makes sense, so I'll close this for now. |
If/When this is approved we need another PR to also use these values in the run/build scripts per language to fully implement the CLICS spec. Given that we don't implement the draft yet we have some time still.
One import thing is that I've changed the python to pypy3 to be consistent, this will require that this is installed in the host so I'm not sure if the consistency is wanted.