Do not use setfacl anymore to change webapp/var permissions. #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was needed for the eventdaemon to work, but we dont have it anymore. Fixes #558.
eldering
reviewed
Apr 17, 2019
lib/Makefile
Outdated
| @@ -12,12 +12,18 @@ $(OBJECTS): %$(OBJEXT): %.c %.h | |||
| clean-l: | |||
| rm -f $(OBJECTS) | |||
|
|
|||
| ifeq "$(FHS_ENABLED)" "yes" | |||
There was a problem hiding this comment.
DESTDIR should never be prepended here, since WEBAPP_DIR is later used only as contents inside files, not for actual paths that things are installed to. See for an explanation https://www.gnu.org/prep/standards/html_node/DESTDIR.html
When we moved some stuff from webapp/Makefile to webapp/app/Makefile, it seems we forgot these things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was needed for the eventdaemon to work, but we dont have it anymore. Fixes #558.