Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve raw cli usage #11

Merged
merged 10 commits into from
Sep 5, 2021
Merged

Improve raw cli usage #11

merged 10 commits into from
Sep 5, 2021

Conversation

DRSchlaubi
Copy link
Owner

@DRSchlaubi DRSchlaubi commented Sep 3, 2021 •
edited

This PR aims at improving the usage of the library as a CLI.

  • Command dependent help messages (-h on all commands)
  • Usage without using TUI
  • Complex file paths (../, ~/, etc)
  • Input validation on args
  • i18n on all args

@DRSchlaubi
Improve raw cli usage
c08a3e7 
- Make TUI entirely optional
- support more complex file paths everywhere (e.g. ../, ~ ./)
@DRSchlaubi DRSchlaubi self-assigned this Sep 3, 2021
@DRSchlaubi DRSchlaubi added enhancement New feature or request help wanted Extra attention is needed labels Sep 3, 2021
NyCodeGHG
NyCodeGHG approved these changes Sep 3, 2021
View reviewed changes
Copy link
Contributor

@NyCodeGHG NyCodeGHG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DRSchlaubi DRSchlaubi marked this pull request as draft September 3, 2021 16:19
@DRSchlaubi
Properly terminate HTTP client for faster process termination
91e8d34
@DRSchlaubi
Make new command fully cli capable
dffbc91 
- Fix NPEs in option/flag mixins
- Add ASCII mode for more basic terminals
@DRSchlaubi
Improve progress communication
f4bae09 
- Replace console.dart with interact.dart
- Add spinners on expensive tasks to indicate progress outside verbose mode
@DRSchlaubi
Display download progress in Human talk instead of computer slang (BE…
1e0388b 
…EP BOP)
@DRSchlaubi
Add input validation on CLI options
0b77c90 
- Fix jvm-version flag
- Forward -y to JDK downloader
@DRSchlaubi
Bump interact version
4f021e4
@DRSchlaubi
Optimize resource closing
db4a0ef
@DRSchlaubi
Update remaining localization strings
bf8e7ba
@DRSchlaubi
Copy link
Owner Author

Gonna wait for #12 before we merge this

DRSchlaubi added a commit that referenced this pull request Sep 5, 2021
@DRSchlaubi
Update interact to 2.1.1 (Fix #11)
f4a7872
@DRSchlaubi DRSchlaubi linked an issue Sep 5, 2021 that may be closed by this pull request
Cursor invisible after exiting with Ctrl+C #12
Closed
@DRSchlaubi DRSchlaubi marked this pull request as ready for review September 5, 2021 07:33
@DRSchlaubi DRSchlaubi changed the base branch from main to develop September 5, 2021 07:33
@DRSchlaubi DRSchlaubi merged commit 27c558d into develop Sep 5, 2021
@DRSchlaubi DRSchlaubi deleted the feature/cli branch September 5, 2021 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NyCodeGHG NyCodeGHG NyCodeGHG approved these changes

Assignees

@DRSchlaubi DRSchlaubi

Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cursor invisible after exiting with Ctrl+C
2 participants
@DRSchlaubi @NyCodeGHG