Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No locale for the recycling recipes #2

Closed
DRY411S opened this issue Jun 12, 2016 · 9 comments
Closed

No locale for the recycling recipes #2

DRY411S opened this issue Jun 12, 2016 · 9 comments
Assignees

Comments

@DRY411S
Copy link
Owner

DRY411S commented Jun 12, 2016

If a recycling recipe produces more than one result, there is no locale setting for it.

This problem can be partially fixed for 'vanilla' recycling, when the mod can be sure of what things require recycling, but when the mod finds non-vanilla recipes for other mods, this mod won't have a locale setting available.

@DRY411S DRY411S added the bug label Jun 12, 2016
@DRY411S DRY411S self-assigned this Jun 12, 2016
@Simcra
Copy link

Simcra commented Jul 10, 2016

Try removing the prefix from recipes and adding a suffix of -9999 or some arbitrary number, if I remember correctly, they will inherit their regular recipe locale.

@DRY411S
Copy link
Owner Author

DRY411S commented Jul 10, 2016

Try removing the prefix from recipes and adding a suffix of -9999 or some arbitrary number, if I remember correctly, they will inherit their regular recipe locale.

Can you reference something on the net that confirms this? I cannot find anything.

@Simcra
Copy link

Simcra commented Jul 10, 2016

In my mod Surfaces (https://github.com/Simcra/Surfaces) I have no recipe-name in my locale file and my recipes are all localised in-game, there is no documentation that confirms this. Further clarification: if you have a mod which adds recipes like "ladder", "ladder-1", "ladder-2", "ladder-3", each of incremented recipe names will copy the locale from the main recipe unless specifically stated. You would have to check data.raw for these incrementally and set the name of the reverse recipe to the next available number recipe. For example: if I have wood-plank, wood-plank-1, wood-plank-2, you'd add wood-plank-3, wood-plank-4 and wood-plank-5 as the reverse recipes and they would all gain the locale from wood-plank.

@DRY411S
Copy link
Owner Author

DRY411S commented Jul 12, 2016

Thanks for the hint. I will take a look. It doesn't fix the overall problem though that Factorio assumes that an assembling machine produces only one output. The locale 'reverse recipe' name for the Recycling Machine is used for the inputs AND the outputs (unless there is only 1 output).

@DRY411S
Copy link
Owner Author

DRY411S commented Jul 12, 2016

This link is much better advice. It's in test at the moment.

Factorio forum post

DRY411S added a commit that referenced this issue Jul 12, 2016
Migration for: #9
Enhancement: #13
Vanilla locale support: #2
@DRY411S
Copy link
Owner Author

DRY411S commented Jul 12, 2016

Vanilla locale added. Reclassifying as an enhancement to support other mods.

@DRY411S
Copy link
Owner Author

DRY411S commented Jul 18, 2016

Locale for Bob's Mods also added in v0.13.15

@DRY411S
Copy link
Owner Author

DRY411S commented Jul 27, 2016

Locale for 5dim's mods added in v0.13.16

@DRY411S
Copy link
Owner Author

DRY411S commented Jul 27, 2016

This is now fixed for Vanilla, Yuoki Industries, Bob's Mods and 5dim Mods. Every individual mod's locale issue will be raised as a separate issue.

DRY411S added a commit that referenced this issue Jul 27, 2016
Fix: #2
Fix: #15
Fix: #17
Fix: #21
DRY411S added a commit that referenced this issue Jul 27, 2016
Fix: #2
Fix: #15
Fix: #17
Fix: #21
DRY411S added a commit that referenced this issue Jul 27, 2016
Fix: #2
Fix: #15
Fix: #17
Fix: #21
DRY411S added a commit that referenced this issue Jul 27, 2016
Fix: #2
Fix: #15
Fix: #17
Fix: #21
DRY411S added a commit that referenced this issue Jul 27, 2016
Fix: #2
Fix: #15
Fix: #17
Fix: #21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants