DSi-Based themes: Fix broken game detection when sorting by recent #2433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mentusfentus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Fixes #2432: In my previous pull request, I made an oversight that broke game detection when sorting by recently played. This caused the game to launch with incorrect information, such as the wrong game type, region, or AP-patch.
This happened because the app launching code depended on the
CURPOSvariable, and my code modified its value right before the game launched. This led to TWLmenu failing to detect the game properly.To fix this, the app launching code now uses the variable
cursorPosOnScreeninstead ofCURPOS. This name matches the one used in romsel_akmenu for consistency.Where have you tested it?
Pull Request status