Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use actual image size instead of preset sizes for box art #857

Merged
merged 2 commits into from Jan 4, 2020

Conversation

Epicpkmn11
Copy link
Member

What's changed?

  • This makes the box art use the actual size of the image its drawing instead of a preset for that type of rom
  • Any size from 0x0 to 256x192 should work and bigger are ignored (though you don't really want to go larger than the user photo picture)
  • Both cache and non-cache modes are working for me (DSi), however I can't test on flashcard

Where have you tested it?

DSi (K) with latest TWiLight & Unlaunch.

Video: (Spirit Tracks is 100x100, Heart Gold is 256x192, ホワイト is 258x192 (too big, so skipped))
out


Pull Request status

  • This PR has been tested using the provided devkitPro, devkitARM, and EasyGL2D.

@RocketRobz
Copy link
Member

Any chance this can be implemented to quick menu as well?

@Epicpkmn11
Copy link
Member Author

Oh yeah, I kinda forgot about that ;P
Just give me a sec, it should be easy

@Epicpkmn11
Copy link
Member Author

Done!

@RocketRobz RocketRobz merged commit fccf363 into DS-Homebrew:master Jan 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants