Removing the deprecated cbv/share route
#191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgeCodes19
commented
Aug 21, 2024
acouch
reviewed
Aug 21, 2024
Co-authored-by: Aaron Couch <aaroncouch@navapbc.com>
tdooner
approved these changes
Aug 21, 2024
| payments: @payments | ||
| ).summary_email.deliver_now | ||
| @cbv_flow.touch(:transmitted_at) | ||
| end |
| <% unless has_consent %> | ||
| <h2><%= t(".consent_to_authorize_use_title") %></h2> | ||
| <%= f.check_box(:consent_to_authorized_use, { 'label': site_translation(".consent_to_authorize_use_html") }) %> | ||
| <% end %> |
There was a problem hiding this comment.
Not sure why we want to hide the consent box if they've already checked it?
There was a problem hiding this comment.
Hmm.... this is carryover logic. I have the same thought. Maybe to prevent from updating the consented at time?
|
|
||
| before do | ||
| session[:cbv_flow_invitation] = cbv_flow_invitation | ||
| session[:cbv_flow] = cbv_flow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Resolves FFS-1304
Changes
cbv/share#showroutecbv/share#show routeContext for reviewers
The
cbv/share#showroute is now obsolete since we've moved the share with caseworker button to the summaries page.