-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing the deprecated cbv/share
route
#191
Conversation
Co-authored-by: Aaron Couch <aaroncouch@navapbc.com>
payments: @payments | ||
).summary_email.deliver_now | ||
@cbv_flow.touch(:transmitted_at) | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dig it.
<% unless has_consent %> | ||
<h2><%= t(".consent_to_authorize_use_title") %></h2> | ||
<%= f.check_box(:consent_to_authorized_use, { 'label': site_translation(".consent_to_authorize_use_html") }) %> | ||
<% end %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why we want to hide the consent box if they've already checked it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm.... this is carryover logic. I have the same thought. Maybe to prevent from updating the consented at time?
|
||
before do | ||
session[:cbv_flow_invitation] = cbv_flow_invitation | ||
session[:cbv_flow] = cbv_flow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch
Ticket
Resolves FFS-1304
Changes
cbv/share#show
routecbv/share#show route
Context for reviewers
The
cbv/share#show
route is now obsolete since we've moved the share with caseworker button to the summaries page.