Mg 948 consistent results #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multiple controllers will be easier to test, reason about, and simultaneously edit as we continue development. This commit splits up the controllers as such: * All CBV flow pages still have URLs under `/cbv/` * The controllers are nested in the `app/controllers/cbv` directory, and are within a new `Cbv` Ruby module accordingly. E.g. `/cbv/entry` is in `app/controllers/cbv/entries_controller.rb` and the class name is `Cbv::EntriesController`. * Common functionality is extracted into a `Cbv::BaseController` which all pages inherit from. This refactor also changes a couple other things: 1. The invitation URL is now not in the `/cbv/` URL path. It is now `/invitations/new?secret=[secret]`. I've added a redirect. 2. Moves I18n keys to relative keys where possible [Finishes FFS-807](https://jiraent.cms.gov/browse/FFS-807)
allthesignals
changed the base branch from
main
to
td/refactor-cbv-flow-into-multiple-controllers-ffs-807
Base automatically changed from
td/refactor-cbv-flow-into-multiple-controllers-ffs-807
to
main
June 24, 2024 19:33
allthesignals
force-pushed
the
mg-948-consistent-results
branch
from
5a929de
to
8b2672a
Compare
tdooner
approved these changes
Jun 24, 2024
| onSuccess: this.onSignInSuccess.bind(this), | ||
| })); | ||
| } | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Resolves 948
Changes
Adds new event hook.
TODO:
Context for reviewers
Leverages ninety_days_synced event for more sensible and consistent results. Also filters by "90 days ago".
We must re-run the Webhook step for production! We need to subscribe to this new event or it won't work