Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Styletron #113

Closed
impressivewebs opened this issue Nov 9, 2017 · 4 comments · Fixed by #114
Closed

Add Styletron #113

impressivewebs opened this issue Nov 9, 2017 · 4 comments · Fixed by #114

Comments

@impressivewebs
Copy link

I believe Styletron would qualify for inclusion in this playground, correct?
@DSchau
Copy link
Owner

DSchau commented Nov 9, 2017

I would love it (and PRs welcome :)).

I know I tried in the past, and ran into some issues, but could've just been doing things foolishly. In general, anything that doesn't require a babel plugin for functionality should work just fine!

@DSchau
Copy link
Owner

DSchau commented Nov 9, 2017

Just kidding, I got it :) Main thing I wasn't doing was using the StyletronProvider. Woo hoo!

Will push up a branch and get to it later tonight. I'll close this when done :)

DSchau added a commit that referenced this issue Nov 9, 2017
@DSchau
feat: add styletron
9f9cceb 
Fixes #113
@DSchau DSchau mentioned this issue Nov 9, 2017
Merged
4 tasks
@impressivewebs
Copy link
Author

impressivewebs commented Nov 9, 2017 •
edited
Loading

Nice, that was fast!

I usually come across other libraries like this when researching stuff for my newsletter so I'll let you know if there are any others that can be added. I'm pretty sure I've featured others in past issues, but I can't remember them specifically.

@DSchau
Copy link
Owner

DSchau commented Nov 10, 2017

Awesome yeah, please let me know!

I try to keep pretty current in this space, but anyone can miss something!

DSchau added a commit that referenced this issue Nov 10, 2017
@DSchau
feat: add styletron (#114)
aac3e03 
* feat: add styletron

Fixes #113

* test: update snapshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add styletron DSchau/css-in-js-playground
2 participants
@impressivewebs @DSchau