Update GitHub Actions #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build Commit: - Run when tests or Directory props are modified - Run tests after building - Can be ran manually Build PR: - Fix incorrect formatting on the PR title - Run when a PR is opened, pulls the base branch's commits, is reopened, marked as ready for review - Run when tests or Directory props are modified - Run tests after building Regenerate Image Files: - Renamed from "Regenerate Resource Files" to "Regenerate Image Files" - Added the write-all permission for committing changes Publish: - Runs on every branch instead of specifically master branch - Added the `/p:Version` CLI arg, which copies the release's tag name - Removed testing publish when project build files are modified, by request
|
why do we need generate-images |
@InFTord |
akiraveliara
requested changes
Aug 25, 2023
| @@ -33,7 +26,7 @@ jobs: | |||
| - name: Publish NuGet packages | |||
| run: | | |||
| mkdir build | |||
| dotnet pack -c Release -o build | |||
| dotnet pack -c Release -o build /p:Version=${{ github.event.release.tag_name }} | |||
There was a problem hiding this comment.
this doesn't work for two reasons.
-ois unsupported on solution level, that's what we use artifacts output for. no morebuildfolders.github.event.release.tag_namewill usually contain a precedingv; and we might want to version different packages differently. imo the best way to handle this is to just not touch it at all and leave it up to the csproj files
There was a problem hiding this comment.
-ois very much supported on a solution level- ok
There was a problem hiding this comment.
- mb, i forgot that sdk 7.0.201 reenabled it; but we should still use artifacts output for the reasons listed on discord
| run: dotnet build |
There was a problem hiding this comment.
(potentially for future reference)
ideally we want to pass the run number and hash here so that we can build assembly metadata from them if/when we add dev builds. not a priority right now though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build Commit:
Build PR:
Regenerate Image Files:
Publish:
/p:VersionCLI arg, which copies the release's tag nameGenerate-Images.sh:
generate-assets.shtogenerate-images.sh