Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LRRP Latitude Parsing Produces Incorrect Hemisphere #1118

Closed
DSheirer opened this issue Nov 28, 2021 · 0 comments
Closed

LRRP Latitude Parsing Produces Incorrect Hemisphere #1118

DSheirer opened this issue Nov 28, 2021 · 0 comments
Assignees
@DSheirer
Milestone
Build 0.5.0

Comments

@DSheirer
Copy link
Owner

Testing against southern hemisphere LRRP test data indicates that the LRRP latitude field is composed of a leading hemisphere flag followed by a 31-bit integer. This is different than test data indicates for the longitude value, which reflects the field containing a two's complement 32-bit integer.
@DSheirer DSheirer added this to the Build 0.5.0 milestone Nov 28, 2021
@DSheirer DSheirer self-assigned this Nov 28, 2021
DSheirer pushed a commit that referenced this issue Nov 28, 2021
#1118 LRRP Latitude Hemisphere parsing. Updates parser to treat latit…
b82ba73 
…ude value as a 1-bit hemisphere flag followed by a 31-bit integer. Previously, this field was parsed as a 32-bit two's complement field.

There may be two separate formats that are used for LRRP position fields where one treats the value as a two's complement field and the other as a 1-bit hemisphere indicator followed by a 31-bit positive integer.  If so, we'll need to expose a user-selectable flag to toggle one format or the other.

For now, this change won't impact any Northern hemisphere users.
@DSheirer DSheirer mentioned this issue Nov 28, 2021
Merged
DSheirer added a commit that referenced this issue Nov 28, 2021
@DSheirer
#1118 LRRP Latitude Hemisphere parsing. Updates parser to treat latit…
f0f0329 
…ude value as a 1-bit hemisphere flag followed by a 31-bit integer. Previously, this field was parsed as a 32-bit two's complement field. (#1119)

There may be two separate formats that are used for LRRP position fields where one treats the value as a two's complement field and the other as a 1-bit hemisphere indicator followed by a 31-bit positive integer.  If so, we'll need to expose a user-selectable flag to toggle one format or the other.

For now, this change won't impact any Northern hemisphere users.

Co-authored-by: Dennis Sheirer <dsheirer@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DSheirer DSheirer

Labels
None yet
Projects
None yet
Milestone
Build 0.5.0
Development

No branches or pull requests
1 participant
@DSheirer