Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Channel TEARDOWN Is Delayed #1178

Closed
DSheirer opened this issue Mar 19, 2022 · 1 comment · Fixed by #1185
Closed

Channel TEARDOWN Is Delayed #1178

DSheirer opened this issue Mar 19, 2022 · 1 comment · Fixed by #1185
Milestone
Build 0.5.0

Comments

@DSheirer
Copy link
Owner

DSheirer commented Mar 19, 2022 •
edited

Channel teardown appears to be happening sequentially on a 2-second interval. It appears that when you have multiple channels that all need teardown at the same time, that they only teardown on a 2-second interval and sequentially, versus teardown as/when needed.
@DSheirer DSheirer added this to the Build 0.5.0 milestone Mar 19, 2022
@DSheirer
Copy link
Owner Author

ChannelProcessingManager.receive(channelEvent) is currently synchronized. This is causing the channel starts and stops to happen sequentially. With the change to use dedicated threads (from thread pool) and changing the tuner channel source to block on shutdown, this is causing this timing issue to be more pronounced.

Update the ChannelProcessingManager to move the locking down to a finer-grained level so that more events can be processed in parallel.

DSheirer pushed a commit that referenced this issue Mar 20, 2022
#1178 removes synchronization on channel processing manager's source …
f16122a 
…event handler to enable more fine-grained channel start/stop event processing. This was causing the channel start and stop events to occur sequentially.
@DSheirer DSheirer mentioned this issue Mar 21, 2022
Merged
DSheirer pushed a commit that referenced this issue Mar 21, 2022
#1178 removes synchronization on channel processing manager's source …
926336b 
…event handler to enable more fine-grained channel start/stop event processing. This was causing the channel start and stop events to occur sequentially. Adds stream processing with coordinated heartbeat.
DSheirer added a commit that referenced this issue Mar 21, 2022
@DSheirer
#1178 removes synchronization on channel processing manager's source …
1b80f5f 
…event handler to enable more fine-grained channel start/stop event processing. This was causing the channel start and stop events to occur sequentially. Adds stream processing with coordinated heartbeat. (#1185)

Co-authored-by: Dennis Sheirer <dsheirer@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Build 0.5.0
Development

Successfully merging a pull request may close this issue.

1178 channel teardown delayed DSheirer/sdrtrunk
1 participant
@DSheirer