Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alias Identifers tooltips for DMR not quite correct #1393

Closed
hockeyref2 opened this issue Jan 1, 2023 · 1 comment · Fixed by #1425
Closed

Alias Identifers tooltips for DMR not quite correct #1393

hockeyref2 opened this issue Jan 1, 2023 · 1 comment · Fixed by #1425
Assignees
@DSheirer
Milestone
Build 0.5.1

Comments

@hockeyref2
Copy link

In Playlist Editor ->Aliases->Identifiers..
For talkgroup, talkgroup range and radio range....
DMR tooltips were incorrect (for example showing 0-FFFFFFF when in decimal format, when the program wants 1-16777215.

In TalkgroupEditor.java I changed the minimum for DMR to 1 from 0 (lines 242-245)
In TalkgroupRangeEditor.java, I added DMR category with proper tooltips (lines 317-320)
In RadioIdRangeEditor.java, I added DMR category with proper tooltips (lines 303-306)

updated tg id.zip
DSheirer pushed a commit that referenced this issue Jan 20, 2023
#1393 Updates DMR Talkgroup and Radio ID editors to use correct forma…
35d26fe 
…tting. Patch submitted by @hockeyref2
@DSheirer DSheirer mentioned this issue Jan 20, 2023
Merged
DSheirer added a commit that referenced this issue Jan 20, 2023
@DSheirer
#1393 Updates DMR Talkgroup and Radio ID editors to use correct forma…
3567fdf 
…tting. Patch submitted by @hockeyref2 (#1425)

Co-authored-by: Denny Sheirer <sheirerd@ainfosec.com>
@DSheirer
Copy link
Owner

@hockeyref2 Thanks very much! I included logging for when we can't find an editor for the specific protocol/format so that we can catch this oversight earlier in the development process for future protocols.

@DSheirer DSheirer added this to the Build 0.5.1 milestone Jan 20, 2023
@DSheirer DSheirer self-assigned this Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DSheirer DSheirer

Labels
None yet
Projects
None yet
Milestone
Build 0.5.1
Development

Successfully merging a pull request may close this issue.

#1393 DMR Talkgroup & Radio ID Editors Should Use Correct Formats DSheirer/sdrtrunk
2 participants
@DSheirer @hockeyref2