Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radio Reference Import - Temporary Site With Invalid County ID #1735

Closed
DSheirer opened this issue Nov 14, 2023 · 0 comments · Fixed by #1741
Closed

Radio Reference Import - Temporary Site With Invalid County ID #1735

DSheirer opened this issue Nov 14, 2023 · 0 comments · Fixed by #1741
Labels
Milestone

Comments

@DSheirer
Copy link
Owner

sdrtrunk Version
master

Describe the bug
When users try to access this North Carolina, Mecklenberg County UASI system, the editor shows an API error: https://www.radioreference.com/db/sid/6561

as described here: https://forums.radioreference.com/threads/sdr-trunk-rr-import.465400/#post-3921382

On investigation, there is a new 'TEMP' site that's been added to the system that is reporting a county ID value of 99,999. On attempting to retrieve the county info for that county ID, we get a null response and therefore produce an error.

Email submitted to RR asking of 99,999 is a sentinel value indicating a 'no county' identifier.

Expected behavior
If 99,999 is a sentinel value indicating 'No County', then update SystemEditor:297 to exclude the query when the county ID value is 99,999 or when the value is not greater than zero.

@DSheirer DSheirer added the bug label Nov 14, 2023
@DSheirer DSheirer added this to the Version 0.6.0 milestone Nov 14, 2023
DSheirer pushed a commit that referenced this issue Nov 15, 2023
…cate county unknown for sites of a system.
DSheirer added a commit that referenced this issue Nov 15, 2023
…nty-id-temp-site

#1735 Radio Reference API - Temporary Site With County ID 99999 - Unknown Location
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant