Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USB Hotplug Support Can Block UI Thread #1827

Closed
DSheirer opened this issue Feb 8, 2024 · 0 comments · Fixed by #1828
Closed

USB Hotplug Support Can Block UI Thread #1827

DSheirer opened this issue Feb 8, 2024 · 0 comments · Fixed by #1828
Assignees
@DSheirer
Labels
bug high
Milestone
Version 0.6.1

Comments

@DSheirer
Copy link
Owner

DSheirer commented Feb 8, 2024

sdrtrunk Version
master

Describe the bug

A tuner error that causes the tuner to be stopped and removed can block the Swing User Interface (UI) thread on trying to remove the tuner.

DiscoveredTunerModel:246 invokes EventQueuue.invokeAndWait() while it already holds a lock and the launched runnable, running on the UI thread, attempts to acquire the same lock, causing a deadlock.

The sdrtrunk application will either freeze or turn white as an indicator that the UI thread is deadlocked.

Expected behavior

The code should be changed to spin off the UI runnable and not wait for it to complete.
@DSheirer DSheirer self-assigned this Feb 8, 2024
@DSheirer DSheirer added this to the Version 0.6.1 milestone Feb 8, 2024
DSheirer pushed a commit that referenced this issue Feb 9, 2024
#1827 USB Hotplug support callback can block the UI thread causing bl…
f957305 
…ank white screen.
@DSheirer DSheirer mentioned this issue Feb 9, 2024
Merged
DSheirer added a commit that referenced this issue Feb 9, 2024
@DSheirer
#1827 USB Hotplug support callback can block the UI thread causing bl…
0491b08 
…ank white screen. (#1828)

Co-authored-by: Dennis Sheirer <dsheirer@github.com>
@DSheirer DSheirer mentioned this issue Feb 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DSheirer DSheirer

Labels
bug high
Projects
None yet
Milestone
Version 0.6.1
Development

Successfully merging a pull request may close this issue.

#1827 UI Thread Deadlock From USB Hotplug Support Callback DSheirer/sdrtrunk
1 participant
@DSheirer