Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error message for R828D Tuner #1140

Merged
merged 1 commit into from Mar 12, 2022
Merged

Conversation

JaredLThompson
Copy link
Contributor

Currently, when the R828D Tuner is detected, the only message that gets sent to the log is Unknown Device. For example:

14:03:22.625 INFO i.g.d.s.t.TunerManager - USB Bus [1] Device [0BDA:2838] Unknown Device - Class 0 [25MB/128MB 19%]

There is already a well constructed exception message being constructed in TunerManager.java:

private TunerInitStatus initRTL2832Tuner(TunerClass tunerClass, Device device, DeviceDescriptor deviceDescriptor)
   {
  
           case RAFAELMICRO_R828D:
           case UNKNOWN:
           default:
               reason = "SDRTRunk doesn't currently support RTL2832 Dongle with [" + tunerType.toString() +
                   "] tuner for tuner class[" + tunerClass.toString() + "]";
               break;
       }

After adding the mlog(reason) before the break; command, the error message is more descriptive:

15:00:39.982 INFO  i.g.d.s.t.TunerManager - SDRTRunk doesn't currently support RTL2832 Dongle with [RAFAELMICRO_R828D] tuner for tuner class[USB Tuner:RTL2832_VARIOUS Vendor:RTL2832 Device:SDR Address:0BDA:2838]  [26MB/128MB 20%]
15:00:39.983 INFO  i.g.d.s.t.TunerManager - USB Bus [1] Device [0BDA:2838]  Unknown Device - Class 0  [26MB/128MB 20%]

@DSheirer DSheirer merged commit 2ab0c78 into DSheirer:master Mar 12, 2022
@DSheirer DSheirer self-assigned this Mar 12, 2022
@DSheirer DSheirer added this to the Build 0.5.0 milestone Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants