Fix Rdio Scanner API call to comply with HTTP standards #1730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Eric! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running into some weird issues with my proxy that was processing Rdio scanner API calls, it turns out that SDRTrunk doesn't send a valid HTTP request, so not all servers can process it correctly. There cannot be two content type headers, so I'm removing the
audio/mpegone as it's able to be derived from the.mp3filename in Rdio scanner itself. Additionally, there was an extra space in the multipart form filename syntax, which may also cause some issues.I've verified that the changes work fine with Rdio scanner.