Add a SuppressWarnings annotation for LGTM as it doesn't detect that …

…we fixed this.
DSpace · Jul 31, 2020 · cf2f50d · cf2f50d
1 parent 4410435
commit cf2f50d
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/dspace-server-webapp/src/main/java/org/dspace/app/rest/ShibbolethRestController.java b/dspace-server-webapp/src/main/java/org/dspace/app/rest/ShibbolethRestController.java
@@ -49,6 +49,9 @@ public void afterPropertiesSet() {
             .register(this, Arrays.asList(new Link("/api/" + AuthnRest.CATEGORY, "shibboleth")));
     }
 
+    // LGTM.com thinks this method has an unvalidated URL redirect (https://lgtm.com/rules/4840088/) in `redirectUrl`,
+    // even though we are clearly validating the hostname of `redirectUrl` and test it in ShibbolethRestControllerIT
+    @SuppressWarnings("lgtm[java/unvalidated-url-redirection]")
     @RequestMapping(method = RequestMethod.GET)
     public void shibboleth(HttpServletResponse response,
             @RequestParam(name = "redirectUrl", required = false) String redirectUrl) throws IOException {