Improved fix: override missing register method in VersionedDOIIdentif…

…ierProvider
DSpace · May 12, 2023 · f844ca3 · f844ca3
1 parent 1d355b7
commit f844ca3
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/dspace-api/src/main/java/org/dspace/identifier/VersionedDOIIdentifierProvider.java b/dspace-api/src/main/java/org/dspace/identifier/VersionedDOIIdentifierProvider.java
@@ -153,6 +153,15 @@ public void register(Context context, DSpaceObject dso, String identifier) throw
         register(context, dso, identifier, this.filter);
     }
 
+    @Override
+    public String register(Context context, DSpaceObject dso, Filter filter)
+            throws IdentifierException {
+        String doi = mint(context, dso, filter);
+        register(context, dso, doi, filter);
+
+        return doi;
+    }
+
     @Override
     public void register(Context context, DSpaceObject dso, String identifier, Filter filter)
         throws IdentifierException {

diff --git a/...-server-webapp/src/main/java/org/dspace/app/rest/repository/IdentifierRestRepository.java b/...-server-webapp/src/main/java/org/dspace/app/rest/repository/IdentifierRestRepository.java
@@ -234,8 +234,7 @@ private IdentifierRest registerDOI(Context context, Item item)
             DOIIdentifierProvider doiIdentifierProvider = DSpaceServicesFactory.getInstance().getServiceManager()
                     .getServiceByName("org.dspace.identifier.DOIIdentifierProvider", DOIIdentifierProvider.class);
             if (doiIdentifierProvider != null) {
-                String doiValue = doiIdentifierProvider.mint(context, item, new TrueFilter());
-                doiIdentifierProvider.register(context, item, doiValue, new TrueFilter());
+                String doiValue = doiIdentifierProvider.register(context, item, new TrueFilter());
                 identifierRest.setValue(doiValue);
                 // Get new status
                 DOI doi = doiService.findByDoi(context, doiValue);