Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DS-1360 Porting advanced embargo function to JSPUI #212

Closed
wants to merge 1 commit into from

Conversation

helix84
Copy link
Member

@helix84 helix84 commented May 8, 2013

https://jira.duraspace.org/browse/DS-1360

This pull request is only a rebase of #116 against current master to squash it and remove an unwanted change to build.properties (this one: zuki@25f50b9).

I only tested whether it builds, not whether it works.

@lap82
Copy link
Contributor

lap82 commented May 17, 2013

This use of the private items is not clear see: http://sourceforge.net/mailarchive/message.php?msg_id=30862002
The change of the browse api should be not required because the XMLUI already use it and support private item. Anyway, it could be more appropriate to make evidence in the api of the private/withdrawn status of an item. Now the BrowseItemDAO implementation (both postgres and oracle) have error in retrieving result due to missing discoverable attribute in select clause.

@@ -478,7 +478,7 @@ UL { font-family: "verdana", "Arial", "Helvetica", sans-serif;
text-decoration: none;
vertical-align: middle }

.searchBoxLabelSmall { font-family: "verdana", "Arial", "Helvetica", sans-serif;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this change intentionally? how is it related to the embargo functionality?

@abollini
Copy link
Member

suggestions are been applied in the new PR #235
Closing this PR to manage the one most up-to-date (rebased by helix84)

@abollini abollini closed this Sep 16, 2013
kosarko pushed a commit to kosarko/DSpace that referenced this pull request Jun 9, 2015
@helix84 helix84 deleted the DS-1360 branch February 2, 2016 18:52
saschaszott added a commit to ub-hsu/DSpace that referenced this pull request Nov 1, 2021
saschaszott added a commit to ub-hsu/DSpace that referenced this pull request Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants