Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripts and processes bug #7992

Closed
YanaDePauw opened this issue Oct 12, 2021 · 0 comments · Fixed by #8207
Closed

Scripts and processes bug #7992

YanaDePauw opened this issue Oct 12, 2021 · 0 comments · Fixed by #8207
Assignees
Labels
bug code task Code cleanup task high priority tools: processes Related to Scripts & Processes feature
Milestone

Comments

@YanaDePauw
Copy link
Contributor

The REST code for the scripts and processes does not take into account the "hasArg" value of the configured script options.
Instead, the REST API only exposes the option type. I believe angular will then use this option type to force an argument or not depending on the type.
When the type is a String, which is the default type, an argument will be forced.

As a consequence, when no argument needs to be provided, the type needs to be changed to a boolean as is done here.

This is very unintuitive when adding configuration for new scripts.

This bug was noticed in the review of the harvest script.

Expected behavior

Ideally, the converter should set the type to boolean when no other type is provided and when there should be no argument provided for the parameter instead of having to set the type manually for every parameter.

Related work

This issue was noticed when reviewing the Control collection harvest from the UI PR.

@YanaDePauw YanaDePauw added bug needs triage New issue needs triage and/or scheduling labels Oct 12, 2021
@tdonohue tdonohue added code task Code cleanup task tools: processes Related to Scripts & Processes feature help wanted Needs a volunteer to claim to move forward and removed needs triage New issue needs triage and/or scheduling labels Oct 12, 2021
@tdonohue tdonohue added this to To Do in DSpace 7.x Tier 3: Medium Priority via automation Oct 12, 2021
@tdonohue tdonohue added this to To Do in DSpace 7.3 release via automation Dec 9, 2021
@tdonohue tdonohue moved this from To Do to In Progress in DSpace 7.3 release Feb 10, 2022
@lieven-atmire lieven-atmire removed the help wanted Needs a volunteer to claim to move forward label Feb 17, 2022
YanaDePauw added a commit to atmire/DSpace that referenced this issue Mar 8, 2022
@tdonohue tdonohue added this to the 7.3 milestone Mar 14, 2022
tdonohue added a commit that referenced this issue Apr 13, 2022
milanmajchrak pushed a commit to dataquest-dev/DSpace that referenced this issue Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug code task Code cleanup task high priority tools: processes Related to Scripts & Processes feature
Projects
No open projects
DSpace 7.3 release
  
In Progress
Development

Successfully merging a pull request may close this issue.

4 participants