Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing a canvas dimension test for images that are not processed by ImageIO #8493

Closed
mspalti opened this issue Sep 29, 2022 · 0 comments · Fixed by #8705
Closed

Missing a canvas dimension test for images that are not processed by ImageIO #8493

mspalti opened this issue Sep 29, 2022 · 0 comments · Fixed by #8705
Assignees
@mspalti
Labels
bug integration: IIIF Related to International Image Interoperability Framework (IIIF) support
Milestone
7.6

Comments

@mspalti
Copy link
Member

mspalti commented Sep 29, 2022 •
edited

Describe the bug
This issue is about adding a new test for the IIIF canvas dimensions CLI task.

When images cannot be processed by ImageIO (as is the case with .jp2) a call should be made to the IIIF image server. Now that we have a mock for IIIFApiQueryService it should be possible to add a test for .jp2 images in CanvasDimensionsIT.

This test will also require adding JPEG2000 to the default bitstream registry (which seems a good idea in any case).

Related work
#8402
@mspalti mspalti added bug needs triage New issue needs triage and/or scheduling labels Sep 29, 2022
@mspalti mspalti self-assigned this Sep 29, 2022
@tdonohue tdonohue added integration: IIIF Related to International Image Interoperability Framework (IIIF) support and removed needs triage New issue needs triage and/or scheduling labels Oct 17, 2022
@tdonohue tdonohue added this to the 7.5 milestone Oct 20, 2022
@tdonohue tdonohue removed this from the 7.5 milestone Feb 17, 2023
@mspalti mspalti mentioned this issue Mar 8, 2023
Merged
8 tasks
@tdonohue tdonohue added this to the 7.6 milestone Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mspalti mspalti

Labels
bug integration: IIIF Related to International Image Interoperability Framework (IIIF) support
Projects
No open projects
DSpace 7.6 Release
Status: ✅ Done
Milestone
7.6
Development

Successfully merging a pull request may close this issue.

Added test and format registry entry for JPEG2000 image mspalti/DSpace
2 participants
@tdonohue @mspalti