Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test and format registry entry for JPEG2000 image #8705

Merged
merged 3 commits into from Mar 28, 2023

Conversation

mspalti
Copy link
Member

@mspalti mspalti commented Mar 8, 2023

References

Description

This small PR adds an IT for the iiif-canvas-dimensions command-line operation. The IT verifies that the Cantaloupe image server is queried to get the missing image dimensions for JPEG2000 images.

This PR also adds JPEG2000 to the file format registry. JPEG2000 is a common format (at least for large digitization projects with hi-res images). It's fully supported by Cantaloupe and most other image servers. The IIIF integration doesn't work with jp2 when the format is missing from the registry. (Nor does the new test.)

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & integration tests). Exceptions may be made if previously agreed upon.
  • My PR passes Checkstyle validation based on the Code Style Guide.
  • My PR includes Javadoc for all new (or modified) public methods and classes. It also includes Javadoc for large or complex private methods.
  • My PR passes all tests and includes new/updated Unit or Integration Tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in any pom.xml), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR modifies REST API endpoints, I've opened a separate REST Contract PR related to this change.
  • If my PR includes new configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@mspalti mspalti self-assigned this Mar 8, 2023
@tdonohue tdonohue added this to the 7.6 milestone Mar 8, 2023
@tdonohue tdonohue added bug 1 APPROVAL pull request only requires a single approval to merge. integration: IIIF Related to International Image Interoperability Framework (IIIF) support labels Mar 8, 2023
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @mspalti ! This looks good to me. Gave it a quick test as well (to ensure the JP2 format is created successfully) and it is.

@tdonohue tdonohue merged commit bdb8872 into DSpace:main Mar 28, 2023
@mspalti mspalti deleted the jp2-test branch October 13, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge. bug integration: IIIF Related to International Image Interoperability Framework (IIIF) support
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Missing a canvas dimension test for images that are not processed by ImageIO
2 participants