Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grunt 1.6.x requires Node.js v16 #8676

Closed
alanorth opened this issue Feb 21, 2023 · 3 comments
Closed

grunt 1.6.x requires Node.js v16 #8676

alanorth opened this issue Feb 21, 2023 · 3 comments
Labels
bug interface: XMLUI (obsolete) XMLUI in DSpace versions 1.x through 6.x. Removed in 7.x

Comments

@alanorth
Copy link
Contributor

Describe the bug
The Mirage 2 theme in DSpace 6.x relies on grunt to run tasks during the frontend build. A few weeks ago grunt was updated 1.6.0, which requires Node.js v16. This breaks the build because Mirage 2 is limited to Node.js v14:

error grunt@1.6.1: The engine "node" is incompatible with this module. Expected version ">=16". Got "14.21.2"

DSpace 6 is nearing end of life, but the solution is to pin grunt to version 1.5.x using the ~1.5.3 semver specifier in dspace-xmlui-mirage2/src/main/webapp/package.json.
@alanorth alanorth added bug interface: XMLUI (obsolete) XMLUI in DSpace versions 1.x through 6.x. Removed in 7.x labels Feb 21, 2023
@tdonohue
Copy link
Member

@alanorth : If you wanted to provide a quick fix, we could patch this in dspace-6_x for now & perhaps cut one last (small, important fixes only) 6.x release prior to EOL.

That said, if it's not a priority for you, that's perfectly OK as well. This ticket provides enough clues for anyone to patch this themselves if they are impacted.

alanorth added a commit to ilri/DSpace that referenced this issue Feb 21, 2023
@alanorth
dspace-xmlui-mirage2: pin grunt for Node.js v14
b9da84a 
Grunt 1.6.0 updated its Node.js dependency to version 16. Mirage 2
is a legacy theme that is stuck on Node.js 14, so this breaks the
build. Pin the grunt version to the last 1.5.x release providing
support for Node.js 14 using semver's ~1.5.3 specifier.

Fixes: DSpace#8676
@alanorth alanorth mentioned this issue Feb 21, 2023
Closed
1 task
@alanorth
Copy link
Contributor Author

Easy fix, done! #8677

@alanorth
Copy link
Contributor Author

alanorth commented Jun 6, 2023

Closing as DSpace 6.x is no longer supported. Anyone facing this issue can see how to resolve it here anyway.

@alanorth alanorth closed this as completed Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug interface: XMLUI (obsolete) XMLUI in DSpace versions 1.x through 6.x. Removed in 7.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix grunt version for Mirage 2 build on Node.js v14 alanorth/DSpace
2 participants
@alanorth @tdonohue