DS-2784 Update REST API to Jersey2 #1102
Conversation
| @@ -0,0 +1,13 @@ | |||
| package org.dspace.rest; | |||
There was a problem hiding this comment.
Please add DSpace license header.
|
This looks good to me. Please resolve the missing license header issue. Are you aware of any changes in jersey 1x to 2x that are worth noting? While developing DSpace's REST API, jersey 2 hadn't yet been released. |
|
|
+1 I've run and tested this code, and it everything appears to be working normally. I didn't notice any issues from the Jersey upgrade. |
|
how about null ID in generated link? (it's visible in JSON output) |
| @@ -37,12 +38,13 @@ | |||
| * @author Rostislav Novak (Computing and Information Centre, CTU in Prague) | |||
| * | |||
| */ | |||
| @Component | |||
There was a problem hiding this comment.
ups. sorry for that
|
Sorry for the delay. You can change the link to have the UUID then. The client will already have to parse that field as a string, and it is the best url to access the object. |
|
Ok, I removed legacy ID |
|
@peterdietz is it good to merge yet? I'd like to close some tickets that depend on this. |
Conflicts: dspace-rest/src/main/java/org/dspace/rest/BitstreamResource.java
Conflicts: dspace-rest/src/main/java/org/dspace/rest/HandleResource.java
Conflicts: dspace-rest/src/main/java/org/dspace/rest/common/Item.java dspace-rest/src/main/webapp/WEB-INF/web.xml
|
I have merged this PR. REST API is now Jersey 2. Master + REST is now working. There was a momentary issue with PubMed (dspace-api, bringing jersey2), and REST using jersey1. This is all working now |
[CST-10629] fixed broken code against the ITs methods Approved-by: Andrea Bollini
https://jira.duraspace.org/browse/DS-2784