DS-2656: Tidy up whitespaces, tabs, etc in input-forms.xml

[alanorth]

Generated with the following command:

$ tidy -xml -iq -m -w 0  dspace/config/input-forms.xml

Results in no functional changes, only aesthetic.

[helix84]

I don't like the blank lines removed, that makes readability worse.

[alanorth]

To be fair, it's not meant to be readable to you—it's machine-readable XML. ;)

In our institute I run tidy after every modification I make to our subject terms, before committing to the repo.

[helix84]

The machine doesn't care about this whitespace change in the slightest. The humans who edit it probably do. There's merit in making it the file readable, which is why you are making this PR. I don't object to formatting it, just to one specific formatting change.

[alanorth]

I guess it depends who is editing it. I'm a systems admin, and I edit it in vim in a terminal. It's actually because of our librarians editing it and introducing all manner of white space errors that I started formatting it in the first place!

[mwoodiupui]

I must agree that I'd prefer not to lose the vertical whitespace.

[tdonohue]

Agreed with others that the veritical whitespace would be nice to keep. I'm OK with cleaning up tabbing, trailing spaces though, if this PR was updated.

[alanorth]

It's ok, @tdonohue. I will close this pull request and just continue to format / audit our file for correctness with tidy locally. My main gripe was that our once-yearly rebase on top of new DSpace release branches cause tons of merge conflicts due to whitespace.