DS-3205 : Mispelling in group search table name in xmlui - fixed #1391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Table table = results.addTable("roup-edit-search-group",groups.size() + 1, 1); | ||
|
|
||
| // DS-3205 fix | ||
| // Table table = results.addTable("roup-edit-search-group",groups.size() + 1, 1); |
There was a problem hiding this comment.
This comment is a thoughtful touch, but it isn't necessary to document patches in the code -- git preserves the changes and their authors, and can show them when you want them.
|
+1 obviously correct. The name is unused in stock DSpace and so this change can only improve the code. |
|
Thx Mark. |
tdonohue
added
the
quick win
|
+1, via code review. Obvious fix to a bad typo. Thanks @oooriii ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes fixes the bug