Include the item's title in the request item e-mail just for xmlui #1422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| String title = itemService.getMetadataFirstValue(item, "dc", "title", null, Item.ANY); | ||
|
|
||
| title = title != null ? title : I18nUtil | ||
| .getMessage("jsp.general.untitled", context); |
There was a problem hiding this comment.
Would it not be better to use item.getName() (https://github.com/DSpace/DSpace/blob/master/dspace-api/src/main/java/org/dspace/content/Item.java#L334) & then use StringUtils.isNotBlank() instead of a null check (this will ensure a blank title ("") is also sent as untitled).
|
Thanks for the remarks, I made the corresponding changes. |
| @@ -55,6 +56,7 @@ | |||
| protected HandleService handleService = HandleServiceFactory.getInstance().getHandleService(); | |||
| protected RequestItemService requestItemService = RequestItemServiceFactory.getInstance().getRequestItemService(); | |||
| protected BitstreamService bitstreamService = ContentServiceFactory.getInstance().getBitstreamService(); | |||
| protected ItemService itemService = ContentServiceFactory.getInstance().getItemService(); | |||
There was a problem hiding this comment.
Unclear why itemService is being grabbed here (or why there's an import org.dspace.content.service.ItemService; above). It looks like it never gets used in this class, so there's no need to even pull it in.
|
+1 via code review. Very obvious fix. Thanks! |
tdonohue
added
the
quick win
|
+1 via code review, looks like an obvious fix indeed 👍 |
|
+1 via code review |
4science-it
pushed a commit
to 4Science/DSpace
that referenced
this pull request
Feb 16, 2024
[DSC-1386] Added support to create template item via struct builder Approved-by: Stefano Maffei
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.duraspace.org/browse/DS-3225