Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DS-3179 integration tests for Community/Collection Admin inherited delete permissions #1447

Merged
merged 2 commits into from Jun 29, 2016

Conversation

tdonohue
Copy link
Member

Companion to #1443. This adds/updates Unit and Integration tests that validate Community / Collection Admin inherited deletion permissions.

NOTE: These tests will currently FAIL on master, because of the bug described in
https://jira.duraspace.org/browse/DS-3179

However, if you run these tests using the code in #1443, then they all SUCCEED. This should prove that the fixes in #1443 are correct, and should be merged immediately (followed by or preceded by merger of this PR).

@hardyoyo
Copy link
Member

I've merged #1447 and #1443 as per tdonohue's instructions, and rebased the whole thing on current master, running mvn test -Dmaven.test.skip=false -DskipITs=false and all tests pass. I'd say this looks pretty good. +1

@tdonohue
Copy link
Member Author

Already at +2 and approved during backlog hour. Merging!

@tdonohue tdonohue merged commit 91f5a5c into DSpace:master Jun 29, 2016
@tdonohue tdonohue deleted the DS-3179-integration-tests branch June 29, 2016 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code task Code cleanup task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants