DS-2359 Error when depositing large files via browser (over 2Gb) #1723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwoodiupui
changed the title
tdonohue
added
bug
quick win
|
@PhilipVis , @bram-atmire , I am interested in testing this for inclusion in 6.1. As a baseline, I attempted to upload a 2.4G file via XMLUI (without this patch). The upload gets to 100% and there is no indication of success or failure. Do I need something on the UI side to process a large upload? |
terrywbrady
approved these changes
Jun 27, 2017
|
👍 Code looks good, and this has received another test/review. This is also standalone, so I'm going to merge this for 6.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the change proposed by Bram in jira ticket:
https://jira.duraspace.org/browse/DS-2359
I created a new DSpacePartOnDisk class based on the cocoon PartOnDisk class. This class contains the fix to replace the nast that was causing problems with file uploads that are larger than 2GB.
Update classes that used the PartOnDisk class to use the DSpacePartOnDisk class instead.