DS-3127 (DSpace 6) whitelist of formats allowable in citation pdf url for google scholar #1777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tomdesair : FYI, Travis seems to be having issues with this PR. It hangs each time it attempts to run |
toniprieto
reviewed
Jun 20, 2017
| @@ -73,5 +73,9 @@ google.citation_patent_number = | |||
| google.citation_technical_report_number = | |||
| google.citation_technical_report_institution = dc.publisher | |||
|
|
|||
| #priority whitelist for citation_pdf_url, shortnames are defined in dspace/config/registries/bitstream-formats.xml | |||
| #priority order is defined here, where the first type is the most important | |||
| google.citation.prioritized_types = Adobe PDF, Microsoft Word, Microsoft Word XML, RTF, Photoshop, EPUB | |||
There was a problem hiding this comment.
I think that the PS format from the original recommended whitelist (PDF, PS, DOC/DOCX, RTF, EPUB) should be PostScript and not Photoshop. This whitelist should list textual formats.
|
I don't have access to the branch of this PR so I created a new PR with the fixes: #1785 @toniprieto and @tdonohue Please re-review the new PR. Closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the port of #1735 to DSpace 6. All information can be found there.
I know the branch and commit are named incorrectly, but this is the fix for https://jira.duraspace.org/browse/DS-3127