Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DS-3245: CSV linebreaks not supported by Bulkedit - DSpace 5 backport #1789

Merged
merged 1 commit into from Jun 22, 2018

Conversation

helix84
Copy link
Member

@helix84 helix84 commented Jun 30, 2017

Backport of #1784 for DSpace 5. Tested.

https://jira.duraspace.org/browse/DS-3245

When a multiline field contained empty lines, the importer stopped
reading the file. This reverts a change in 53d387f to stop when the
end of the file has been reached instead.

Fixes https://jira.duraspace.org/browse/DS-3245
@helix84 helix84 added the bug label Jun 30, 2017
@helix84 helix84 added this to the 5.7 milestone Jun 30, 2017
@helix84 helix84 requested a review from terrywbrady June 30, 2017 08:15
@tdonohue tdonohue modified the milestone: 5.7 Jul 12, 2017
@terrywbrady terrywbrady added this to the 5.9 milestone Mar 14, 2018
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This is an exact copy of #1784, and it comes with integration tests to prove it out. Looks great to me.

Copy link
Contributor

@terrywbrady terrywbrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and verified

@terrywbrady terrywbrady merged commit 2a70460 into DSpace:dspace-5_x Jun 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants