Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DS-3698 Correct HAL browser context path #1842

Merged

Conversation

tomdesair
Copy link
Contributor

Copy link
Member

@abollini abollini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with the proposed code. I will make a try late this week but if other can make a fast run to double check and it works feel free to merge.
Please note that this is related to an issue in the Spring HAL library that was reported to the spring community and could be unnecessary in the long run: https://jira.spring.io/browse/DATAREST-971 the latest comment here also suggest to investigate a bit more in our configuration

@abollini abollini added this to the 7.0 milestone Sep 20, 2017
@tomdesair
Copy link
Contributor Author

Indeed, it seems to be related to the issue you mention. Another user mentions the HalBrowserMvcEndpoint class in that ticket, but I'm not sure how to use it. So for now, I think the JavaScript workaround is the easiest solution.

@abollini abollini added the interface: REST API v7+ REST API for v7 and later (dspace-server-webapp module) label Sep 25, 2017
@abollini abollini merged commit ca63b4f into DSpace:master Sep 26, 2017
@tomdesair tomdesair deleted the DS-3698_Correct-HAL-browser-context-path branch September 29, 2017 11:36
@mwoodiupui
Copy link
Member

+1 I just now tested this, after spending too much time trying to figure out why I always got 404 in the HAL Browser but 'curl' worked as expected, and then finding that someone else had already fixed it. Thanks!

@tdonohue tdonohue modified the milestones: 7.0, 7.0preview Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
interface: REST API v7+ REST API for v7 and later (dspace-server-webapp module)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants