Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DS-3791 : Missing date values while faceting #1901

Conversation

jonas-atmire
Copy link
Contributor

@jonas-atmire jonas-atmire commented Dec 20, 2017

Fixes #7138
Make sure the "yearDifference" takes into account that a gap of 10 year contains 11 years

johnpinto1 added a commit to edina/DSpace that referenced this pull request May 15, 2018
were failing to show the current year 2018.

This bug was identified in https://jira.duraspace.org/browse/DS-3791 with the
quick fix in DSpace#1901 which this commit implements.
Copy link
Member

@bram-atmire bram-atmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed by inspection & ok

@tdonohue tdonohue added bug quick win Pull request is small in size & should be easy to review and/or merge labels Aug 3, 2018
@tdonohue tdonohue added this to the 6.4 milestone Aug 3, 2018
@tdonohue tdonohue added the interface: XMLUI (obsolete) XMLUI in DSpace versions 1.x through 6.x. Removed in 7.x label Aug 21, 2018
@tdonohue tdonohue changed the title DS-3791 DS-3791 : Missing date values while faceting Aug 21, 2018
Copy link
Member

@kshepherd kshepherd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, tests OK. Thanks @jonas-atmire !

@kshepherd kshepherd merged commit 3ebb746 into DSpace:dspace-6_x Feb 18, 2020
juliapim pushed a commit to juliapim/DSpace-1 that referenced this pull request Dec 9, 2020
…-values-when-faceting

DS-3791 : Missing date values while faceting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug interface: XMLUI (obsolete) XMLUI in DSpace versions 1.x through 6.x. Removed in 7.x quick win Pull request is small in size & should be easy to review and/or merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants