[DS-3795] bumped google-http-client-jackson2 to 1.23.0 #1909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdonohue
added
high priority
code task
terrywbrady
approved these changes
Jan 19, 2018
tdonohue
reviewed
Jan 19, 2018
| @@ -1395,7 +1395,7 @@ | |||
| <dependency> | |||
| <groupId>com.google.http-client</groupId> | |||
| <artifactId>google-http-client-jackson2</artifactId> | |||
| <version>1.21.0</version> | |||
| <version>1.23.0</version> | |||
There was a problem hiding this comment.
Looks good, but I think we should be syncing the version of google-http-client-jackson2 with the versions of google-http-client and google-api-client (at a minimum). I notice several of these Google dependencies (in the same region in this file) all are synced on the same 1.21.0 version, and I'm not sure that's an accident.
There was a problem hiding this comment.
From the notes here, they all seem to have synced versions/releases: https://developers.google.com/api-client-library/java/
…er suggestion of tdonohue
…services-analytics, heh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.duraspace.org/browse/DS-3795