-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DS-3804] Jar dependency issues running DSpace 7x REST #1921
[DS-3804] Jar dependency issues running DSpace 7x REST #1921
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. One minor request to add in a comment about the temporary dependency exclusions. But, after that, I think this is good to merge
@@ -169,6 +169,20 @@ | |||
<groupId>org.springframework.boot</groupId> | |||
<artifactId>spring-boot-starter-web</artifactId> | |||
<version>${spring-boot.version}</version> | |||
<exclusions> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add a simple comment here that says something like:
<!-- Temporary exclusions until DS-3135 is fixed. Once we are using log4j v2, we should update Spring Boot to utilize it per these instructions: https://docs.spring.io/spring-boot/docs/current/reference/html/howto-logging.html#howto-configure-log4j-for-logging -->
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the jackson exclusion is not required to have the OAI running properly I will prefer to skip it
dspace-oai/pom.xml
Outdated
@@ -159,6 +159,10 @@ | |||
<groupId>org.apache.commons</groupId> | |||
<artifactId>commons-lang3</artifactId> | |||
</exclusion> | |||
<exclusion> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit worried about this exclusion as it is an artifact from an old, different layout, jackson version. The mapper class are now in the jackson-databinder artifact so if we really use this staff we could hit a classnotfound exception at runtime somewhere... BTW the jtwig-spring version in our depency is quite old the new one is: http://jtwig.org/
This PR is a temporary fix to restore stability to the REST build process.
Recommended approach
The more comprehensive approach to the problem will be to upgrade the version of log4j that is in use. DSpace currently uses a version that is at end of life.