Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DS-3434] DSpace fails to start when a database connection pool is supplied through JNDI #1933

Merged
merged 1 commit into from Feb 7, 2018

Conversation

mwoodiupui
Copy link
Member

@mwoodiupui mwoodiupui commented Jan 25, 2018

Ported from the v6 patch.
https://jira.duraspace.org/browse/DS-3434

@mwoodiupui mwoodiupui added the bug label Jan 25, 2018
@mwoodiupui mwoodiupui added this to the 7.0 milestone Jan 25, 2018
@mwoodiupui mwoodiupui changed the title [DS-3434] DSpace fails to start when a databse connection pool is sup… [DS-3434] DSpace fails to start when a databse connection pool is supplied through JNDI Jan 25, 2018
@mwoodiupui mwoodiupui changed the title [DS-3434] DSpace fails to start when a databse connection pool is supplied through JNDI [DS-3434] DSpace fails to start when a database connection pool is supplied through JNDI Feb 2, 2018
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM. It's a port of #1925, which was already approved/merged to dspace-6_x

Copy link
Member

@hardyoyo hardyoyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 by inspection

@mwoodiupui mwoodiupui merged commit 2990729 into DSpace:master Feb 7, 2018
@mwoodiupui mwoodiupui deleted the DS-3434-7 branch February 7, 2018 19:19
@tdonohue tdonohue modified the milestones: 7.0, 7.0preview Jan 26, 2021
4science-it pushed a commit to 4Science/DSpace that referenced this pull request Mar 26, 2024
DSC-725 Orchestrator addon - minor fix

Approved-by: Andrea Bollini
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants