-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align Java code with new Code Style #1952
Conversation
a98fea5
to
c5cd807
Compare
After completing all of the above, I just realized that I neglected to fix our test source code ( So, this PR should be considered "complete" (once Travis finishes approving one last time) and is ready for review/merger. |
👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me (as much as one can look through so many lines!) and builds fine
I'm fine with merging that as soon as the recent introduced conflicts are solved. Thanks to take care of that @tdonohue |
…exception for throws. Disable Javadocs test for public methods.
…ed in previous commits and caused coveralls issues in Travis.
2de1fc2
to
ac0ef05
Compare
I've just finished rebasing this PR on the latest |
Approved in DSpace 7 meeting today. Merging. |
This PR aligns our Java code (on
master
only) with the new Code Style rules detailed in #1895.(NOTE: It is built off a shared branch based on the #1895 branch, so it does include the commits also in #1895)
This PR only changes the following:
private
, empty default constructors for Utility classes (per this rule: http://checkstyle.sourceforge.net/config_design.html#HideUtilityClassConstructor)default
clause toswitch
statements (per new code style)No code changes/refactoring are made in this PR (only exceptions are minor fixes noted above)
Please note the majority of the code fixes in this PR are being automated via IntelliJ IDEA bulk "Reformat Code" tools. For details of the process, please see: https://wiki.duraspace.org/pages/viewpage.action?pageId=90967266#CodeStyleGuide(WIP)-Fixingthecodebase
STATUS: Each module will be cleaned/fixed in a separate commit. As modules are considered "fixed", they will be added to the below list: