DS-3300: Add option to select citation page format (LETTER or A4) - dspace-6_x port #2033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 24, 2018
kshepherd
added
improvement
quick win
kshepherd
commented
Apr 24, 2018
There was a problem hiding this comment.
+1 -- I can't add an actual 'approve' since I created the PR, but the commit is authored by @isido , not me, and I've tested in 6.x (XMLUI bitstreamreader on-demand generation) successfully. I get LETTER size by default and with LETTER configured, and I get A4 when I configure it in citation-page.cfg
jcreel
approved these changes
Apr 25, 2018
juliapim
pushed a commit
to juliapim/DSpace-1
that referenced
this pull request
Dec 9, 2020
…dspace6x_port DS-3300: Add option to select citation page format (LETTER or A4) - dspace-6_x port
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a dspace-6_x port of the master PR for DS-3300 (#2034)