Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DS-3453 - OAI-PMH verb Identify doesn't work on Oracle #2121

Closed
wants to merge 2 commits into from
Closed

DS-3453 - OAI-PMH verb Identify doesn't work on Oracle #2121

wants to merge 2 commits into from

Conversation

arvoConsultores
Copy link
Contributor

@arvoConsultores arvoConsultores commented Jul 17, 2018 •
edited by tdonohue

Port of PR #2112 (originally #1683) to master

Fixes #6806

@tdonohue tdonohue added bug quick win Pull request is small in size & should be easy to review and/or merge labels Jul 18, 2018
@tdonohue tdonohue added this to the 7.0 milestone Jul 18, 2018
tdonohue
tdonohue approved these changes Jul 18, 2018
View reviewed changes
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Code changes seem fine. Unclear if this has been verified to work (i.e. tested), but I'm assuming it likely has been tested?

@tdonohue tdonohue added interface: OAI-PMH Related to the OAI-PMH interface (dspace-oai module) backend: Oracle Related to Oracle database backend labels Aug 21, 2018
@tdonohue tdonohue changed the base branch from master to main July 14, 2020 17:16
@github-actions github-actions bot added the merge conflict PR has a merge conflict that needs resolution label Aug 26, 2020
@tdonohue tdonohue removed this from the 7.0 milestone Apr 28, 2021
@mwoodiupui mwoodiupui mentioned this pull request Sep 7, 2021
Closed
@tdonohue
Copy link
Member

tdonohue commented Sep 7, 2021

@arvoConsultores : Could we get this updated on latest main? If the conflicts can be resolved, I can make sure this gets reviewed sooner rather than later in order to get it fixed in 7.1. Thanks!

@tdonohue
Copy link
Member

tdonohue commented Oct 2, 2023

Closing as Oracle Support was removed in #8822

@tdonohue tdonohue closed this Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdonohue tdonohue tdonohue approved these changes

Assignees
No one assigned
Labels
backend: Oracle Related to Oracle database backend bug interface: OAI-PMH Related to the OAI-PMH interface (dspace-oai module) merge conflict PR has a merge conflict that needs resolution quick win Pull request is small in size & should be easy to review and/or merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DS-3453] OAI-PMH verb Identify doesn't work on Oracle
3 participants
@arvoConsultores @tdonohue @aroman-arvo