DS-4190. Word-break CSS class breaks words without hyphens in Firefox… #2374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshepherd
added
bug
quick win
kshepherd
requested changes
Mar 18, 2019
There was a problem hiding this comment.
this looks great, thanks :)
i'm +1, but just a note: the attribution for the CSS is a nice touch, but to keep things consistent with how other CSS is managed in dspace, removing the comment might keep things cleaner. do you mind making that additional commit to this PR?
|
DS-2963 Word wrap and hyphenation in Item Full View |
kshepherd
approved these changes
Mar 18, 2019
nwoodward
approved these changes
Mar 26, 2020
|
merged, thanks @J4bbi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… and Opera mini
This CSS class change creates hyphens in Firefox / Opera mini when breaking words.