DS-4121: Refactor Entities ITs #2388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbosman
added
component: configurable entities
|
@tomdesair : If you have time, I'd appreciate a quick review from you on this, especially since you had very useful feedback for the original PR #2353 (which this replaces). If you won't have time in the near future, let us know and I'll find someone else to help review. Thanks! |
tdonohue
approved these changes
Mar 29, 2019
There was a problem hiding this comment.
👍 This looks like what I expected. New Builders exist, and all @Ignore tests have been reenabled. Also much fewer changes/tweaks then the previous PR. Thanks @benbosman !
|
Merging, as this is at +2. Remember, this is will also get an additional review in PR #2376 (as this PR is simply committing to that PR#2376's branch). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.duraspace.org/browse/DS-4121
Refactoring the ITs to use the new cleanup method.
The changes have been re-created because they caused problems with the latest master merge
This replaces #2353